This repository has been archived by the owner on Jul 27, 2019. It is now read-only.
Issue #1609 - Improve Kustomize 2 parameters UI #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexmt
commented
May 20, 2019
alexmt
commented
alexec
approved these changes
May 28, 2019
|
|
||
| const pattern = /^(.*):([a-zA-Z0-9._-]*)$/; | ||
|
|
||
| function parseOverwrite(arg: string, overwriteImage: boolean): { name: string; digest?: string, tag?: string } { |
There was a problem hiding this comment.
This is BL in the FE. Perhaps it's time for yarn test?
There was a problem hiding this comment.
I agree. Lets add first unit tests. Working on it
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.